MeB OAuth - latest iteration #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit with basic HTML + CSS
so that we can use the same styles for the signup (create account) page
+ made some links real
Rename the actual tables and some changes that I missed the last time around.
security hardening by detecting code reuse, adding arbitrary fragment. improved token format. made static resources work in dev and prod.
add post method to authorization endpoint
need to look into security concerns about previous oauth attempts' data left in session. because the post data needs to be saved in session while the user is redirected to login. considered server side sessions but not sure if its enough. will probably need timestamps and some hashing to invalidate and careful checks to ensure data between two requests is not mixed. not worth the pains for now.
|
I have applied the last bits of feedback to the OAuth applications pages based on the comments of the design figma We might eventually want to restyle these pages, but as aerozol commented on that figma: "Looks good, just needs to be functional" |
MonkeyDo
reviewed
Nov 7, 2024
Comment on lines
+46
to
+57
| <div className="form-group"> | ||
| <div className="col-md-offset-3 col-md-1"> | ||
| <a href={cancel_url} className="btn btn-default"> | ||
| Cancel | ||
| </a> | ||
| </div> | ||
| <div className="col-md-1" style={{ marginLeft: "8px" }}> | ||
| <button type="submit" className="btn btn-danger"> | ||
| Delete | ||
| </button> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
On smaller sizes the button stack up weirdly.
You can use a bootstrap btn-group instead of using col-* utilities like so:
Suggested change
| <div className="form-group"> | |
| <div className="col-md-offset-3 col-md-1"> | |
| <a href={cancel_url} className="btn btn-default"> | |
| Cancel | |
| </a> | |
| </div> | |
| <div className="col-md-1" style={{ marginLeft: "8px" }}> | |
| <button type="submit" className="btn btn-danger"> | |
| Delete | |
| </button> | |
| </div> | |
| </div> | |
| <div className="btn-group"> | |
| <a href={cancel_url} className="btn btn-default"> | |
| Cancel | |
| </a> | |
| <button type="submit" className="btn btn-danger" style={{ marginLeft: "8px" }}> | |
| Delete | |
| </button> | |
| </div> |
Result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.